[Conformance] Target 2025-11-25 spec in conformance fixtures#303
Open
soyuka wants to merge 1 commit into
Open
Conversation
The conformance test runner (npm @modelcontextprotocol/conformance@0.1.16) covers the 2025-11-25 spec — adding 6 scenarios on top of 2025-06-18, of which json-schema-2020-12 (SEP-1613) requires the fixture to expose a tool whose inputSchema exercises $schema/$defs/$ref/additionalProperties. - tests/Conformance/server.php and tests/Conformance/client.php now negotiate ProtocolVersion::V2025_11_25 via setProtocolVersion(). - The server fixture registers json_schema_2020_12_tool with the schema expected by SEP-1613. Result against `--spec-version 2025-11-25 --suite all`: - server: 42 passed, 1 failed (dns-rebinding-protection, in baseline) - client: 2 passed, 42 failed (all in baseline, baseline check passes)
soyuka
requested review from
CodeWithKyrian,
Nyholm and
chr-hertel
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conformance test runner (
@modelcontextprotocol/conformance@0.1.16) covers the2025-11-25spec — adding 6 scenarios on top of2025-06-18, of whichjson-schema-2020-12(SEP-1613) requires the fixture to expose a tool whoseinputSchemaexercises$schema/$defs/$ref/additionalProperties.Changes
tests/Conformance/server.phpandtests/Conformance/client.phpnow negotiateProtocolVersion::V2025_11_25viasetProtocolVersion().json_schema_2020_12_toolwith the schema expected by SEP-1613.The SDK already supports
ProtocolVersion::V2025_11_25in the enum; this only changes what the conformance fixtures advertise. The SDK'sMessageInterface::PROTOCOL_VERSIONdefault is unchanged (stillV2025_06_18).Results
Run with `--spec-version 2025-11-25 --suite all`:
Test plan