fix: validate version field is valid semver#227
Open
bryan-anthropic wants to merge 1 commit intomainfrom
Open
Conversation
Non-semver version strings (e.g., "2024.03.31.01") pass validation today but cause fatal unrecoverable crashes in Claude Desktop at bootstrap. Add semver validation to catch these before pack/distribution. Fixes #226 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, reopen this pull request to trigger a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcpb validate— non-semver version strings (e.g.,"2024.03.31.01") now fail validation with a descriptive errorsemverpackage (new direct dependency, already present transitively) instead of a fragile regexFixes #226
Context
Non-semver version strings pass
mcpb validateandmcpb packtoday, but cause fatal unrecoverable crashes in Claude Desktop at bootstrap (TypeError: Invalid Version). The app becomes bricked — it crashes on every launch and the broken extension cannot be uninstalled via UI.MANIFEST.md already documents version as "Semantic version (semver)" but nothing enforced it until now.
Test plan
mcpb packwith bad version fails before producing bundlemcpb packwith good version succeeds, bundle unpacks, server responds to MCP initialize🤖 Generated with Claude Code