Conversation
Signed-off-by: Dariusz Jędrzejczyk <dariusz.jedrzejczyk@broadcom.com>
Signed-off-by: Dariusz Jędrzejczyk <dariusz.jedrzejczyk@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes all deprecated APIs and classes in preparation for the 1.0.0 release of the Java MCP SDK. The changes focus on cleaning up the codebase by eliminating deprecated methods, constructors, and entire modules that are no longer needed.
Key Changes
Removed Deprecated Modules
mcp-json-jacksonmodule including:JacksonMcpJsonMapperandJacksonMcpJsonMapperSupplierDefaultJsonSchemaValidatorandJacksonJsonSchemaValidatorSupplierRemoved Deprecated APIs
Server APIs
McpServerSession- Removed deprecated session interface (85 lines)McpAsyncServer.loggingNotification()- Removed method that incorrectly broadcasted to all clients; useMcpAsyncServerExchange.loggingNotification()insteadMcpAsyncServerExchangedeprecated constructor - Removed constructor without transport context supportMcpSyncServerdeprecated methods - Removed 15 lines of deprecated functionalityClient APIs
McpClientSession- Removed deprecated session interface methods (15 lines)HttpClientSseClientTransport.Builder(String)- Removed deprecated constructorSchema/Core APIs
McpSchema- Removed 145 lines of deprecated schema definitionsMcpErrordeprecated constructor - Removed 5 linesImproved Error Handling
McpErrorexceptions with more appropriate exception types:IllegalStateExceptionfor client initialization/configuration errorsIllegalArgumentExceptionfor invalid parameter errorsMcpErrorwith error codes (e.g.,METHOD_NOT_FOUND) for protocol-level errorsAPI Modernization
callparameter; now onlycallHandleris supportedImageContent,EmbeddedResource, removing unused annotation parametersTest Coverage
All tests have been updated to use non-deprecated APIs and continue to pass, ensuring backward compatibility for the migration path while removing the deprecated code paths.
This PR creates a cleaner, more maintainable codebase for the 1.0.0 release by removing legacy APIs that were marked for removal.