fix(cli): use MCP logging levels - #1800
Open
Bortlesboat wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align the CLI's
--log-levelvalidation with the MCP logging specification. The accepted values now come from the SDK'sLoggingLevelSchema, so the CLI no longer rejects valid RFC 5424 levels or forwards the non-spectraceandwarnaliases.Type of Change
Changes Made
Client.setLoggingLevelwithout an unsafe cast.trace/warnat the CLI validation boundary.Related Issues
Fixes #1734
Testing
Test Results and/or Instructions
npm run buildnpm run build-cliMCP spec logging levelsand both non-spec aliases)git diff --checkpassed for both changed filesThe broad CLI suite produced 60 passes and 28 Windows-only failures after successful HTTP responses because Node 24 aborted during transport teardown with
UV_HANDLE_CLOSING. The affected focused tests do not use that teardown path and pass consistently.Checklist
Breaking Changes
None.
Additional Context
Documentation is unchanged because the help text does not enumerate logging levels; its validation error now renders the SDK-derived list automatically. The change is limited to two CLI files.