fix: preserve OAuth DCR client info#1543
Open
mturac wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the OAuth DCR callback flow so dynamically registered client information is kept through token exchange and the returned
client_idis reflected in the Auth Settings sidebar.Type of Change
Changes Made
token_requestwhen provider storage is empty on callback.client_idinto the sidebar/localStorage OAuth Client ID field.Related Issues
Fixes #910
Testing
Test Results and/or Instructions
npm test -- --runTestsByPath src/components/__tests__/AuthDebugger.test.tsx src/__tests__/App.routing.test.tsx --runInBand- 2 suites passed, 25 tests passednpm run lint- passednpm run build-client- passedgit diff --check HEAD~1 HEAD- passedChecklist
npm run lint)Breaking Changes
None.
Additional Context
The issue reports that DCR returns a
client_id, but the Auth Settings field stays blank and token exchange can run without the registered client information after callback state restoration.