jsonrpc2: preserve exact request identities - #1253
Open
andrei-tyk wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON-RPC request IDs are currently decoded through
any, which converts numeric values tofloat64beforeMakeIDconstructs an integer ID. As a result, adjacent IDs such as9007199254740992and9007199254740993collide, responses can be delivered to the wrong in-flight call, and cancellation can target the wrong request.This change keeps only JSON-RPC identity fields as
json.RawMessageuntil they are parsed into the SDK's existing signed 64-bit ID domain. Requests, responses, andnotifications/cancelleduse the same bounded decoder. Numeric and string IDs remain distinct; exact integral decimal and exponent spellings are accepted; fractional and out-of-range values are rejected without aliasing another valid ID. Public APIs and unrelated JSON values are unchanged.Tests cover request and response round trips, signed boundaries, invalid identities, numeric/string distinction, adjacent large IDs correlated out of order, and cancellation of only one adjacent large-ID request.
Local validation:
GOWORK=off go test -count=1 ./internal/jsonrpc2 ./mcpGOWORK=off go test -race -count=1 ./internal/jsonrpc2 ./mcpgofmtandgit diff --check