auth: propagate discovered scopes to DCR metadata before registration#1104
Open
spdeepak wants to merge 1 commit into
Open
auth: propagate discovered scopes to DCR metadata before registration#1104spdeepak wants to merge 1 commit into
spdeepak wants to merge 1 commit into
Conversation
spdeepak
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
auth: propagate discovered scopes to DCR metadata before registration
Fixes #1102
When using
AuthorizationCodeHandlerwithDynamicClientRegistrationConfig, the SDK registers the DCR client before computing the requested scopes. If the caller doesn't setClientRegistrationMetadata.Scope, the client isregistered without any scope restriction, causing
invalid_scopeerrors on strict authorization servers.This change moves scope computation above
handleRegistrationand propagatesdiscovered scopes into the DCR metadata when the caller hasn't explicitly
set a scope. Callers who explicitly set
Scopeare not affected.