Enable complete Tasks extension conformance coverage#1741
Open
PranavSenthilnathan wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7c99928c-a943-49f4-9a63-8b04a0e4d18b
jeffhandley
reviewed
Jul 27, 2026
| public static string SyncTool() => "sync"; | ||
|
|
||
| [McpServerTool(Name = "required-tool")] | ||
| public static string RequiredTool() => "required"; |
Contributor
There was a problem hiding this comment.
Do I understand correctly?
- This return value is never consumed and it's immaterial
- "required-tool" gets recognized by the store, treating the tool as required from the client
- When the client doesn't have the tool, the 2 tests above assert we throw expectedly
- When the client does have the tool, we simply assert that it gets registered as a task
- Not much value in asserting the "required" result since that's the same coverage as the "sync" assert?
If that's all correctly, I suggest we go ahead and assert the "required" result anyway, to close this loop for illustration/documentation. Can't hurt to assert the result too, just in case something in the required tool mechanism ever interfered with the result.
jeffhandley
approved these changes
Jul 27, 2026
jeffhandley
left a comment
Contributor
There was a problem hiding this comment.
Just one minor question/suggestion.
tarekgh
approved these changes
Jul 27, 2026
tarekgh
left a comment
Contributor
There was a problem hiding this comment.
Modulo @jeffhandley comment, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WithTaskscallers to select execution behavior from the tool request without introducing Tasks dependencies in Core or ASP.NET CoreValidation
dotnet build(0 warnings, 0 errors)@modelcontextprotocol/conformance@0.2.0-alpha.9