remove github.com/phayes/permbits dependency - #3282
Open
thaJeztah wants to merge 1 commit into
Open
Conversation
It's trivial to implement an equivalent, and was only used in tests. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3282 +/- ##
==========================================
- Coverage 14.73% 14.70% -0.03%
==========================================
Files 200 200
Lines 93077 93027 -50
==========================================
- Hits 13712 13680 -32
+ Misses 78019 78000 -19
- Partials 1346 1347 +1 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR removes the github.com/phayes/permbits dependency from the main swarmkit/v2 module and vendors, replacing its limited test usage with small local permission-bit helpers.
Changes:
- Drop
github.com/phayes/permbitsfromgo.mod,go.sum, andvendor/modules.txt. - Remove the vendored
vendor/github.com/phayes/permbitspackage. - Update
ca/certificates_test.goto assert permissions viaos.Stat+ local bit checks instead ofpermbits.Stat.
Reviewed changes
Copilot reviewed 2 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vendor/modules.txt | Removes the permbits module entry from vendored module metadata. |
| vendor/github.com/phayes/permbits/README.md | Deletes vendored permbits README as part of dependency removal. |
| vendor/github.com/phayes/permbits/permbits.go | Deletes vendored permbits implementation. |
| vendor/github.com/phayes/permbits/LICENSE | Deletes vendored permbits license file. |
| vendor/github.com/phayes/permbits/godoc.go | Deletes vendored permbits package docs file. |
| vendor/github.com/phayes/permbits/.travis.yml | Deletes vendored permbits CI config file. |
| go.sum | Removes permbits checksums from the main module dependency graph. |
| go.mod | Removes the direct permbits requirement from the main module. |
| ca/certificates_test.go | Replaces permbits-based permission assertions with local helpers using os.FileMode. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's trivial to implement an equivalent, and was only used in tests.
- Description for the changelog