Skip to content

vendor: github.com/google/certificate-transparency-go v1.1.7 - #3279

Open
thaJeztah wants to merge 1 commit into
moby:masterfrom
thaJeztah:bump_certificate_transparency
Open

vendor: github.com/google/certificate-transparency-go v1.1.7#3279
thaJeztah wants to merge 1 commit into
moby:masterfrom
thaJeztah:bump_certificate_transparency

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

Update the dependency to the lowest release containing this commit; google/certificate-transparency-go@8af4dd8

The google.golang.org/genproto/googleapis/api package was moved to a separate module in google.golang.org/genproto@v0.0.0-20230525234044-86246a831fb4.

Attempting to use older versions could result in ambiguous import errors, because google.golang.org/genproto still contained the package, causing a duplicate;

go list ./...
../../../../../pkg/mod/google.golang.org/grpc@v1.79.3/status/status.go:35:2: ambiguous import: found package google.golang.org/genproto/googleapis/rpc/status in multiple modules:
    google.golang.org/genproto v0.0.0-20220706185917-7780775163c4 (/Users/thajeztah/go/pkg/mod/google.golang.org/genproto@v0.0.0-20220706185917-7780775163c4/googleapis/rpc/status)
    google.golang.org/genproto/googleapis/rpc v0.0.0-20251202230838-ff82c1b0f217 (/Users/thajeztah/go/pkg/mod/google.golang.org/genproto/googleapis/rpc@v0.0.0-20251202230838-ff82c1b0f217/status)
../../../../../pkg/mod/go.etcd.io/etcd/api/v3@v3.6.5/etcdserverpb/rpc.pb.go:19:2: ambiguous import: found package google.golang.org/genproto/googleapis/api/annotations in multiple modules:
    google.golang.org/genproto v0.0.0-20220706185917-7780775163c4 (/Users/thajeztah/go/pkg/mod/google.golang.org/genproto@v0.0.0-20220706185917-7780775163c4/googleapis/api/annotations)
    google.golang.org/genproto/googleapis/api v0.0.0-20251202230838-ff82c1b0f217 (/Users/thajeztah/go/pkg/mod/google.golang.org/genproto/googleapis/api@v0.0.0-20251202230838-ff82c1b0f217/annotations)
github.com/moby/swarmkit/swarmd/cmd/external-ca-example

Updating github.com/google/certificate-transparency-go updates the minimum version of google.golang.org/genproto, preventing the problem.

- What I did

- How I did it

- How to test it

- Description for the changelog

Update the dependency to the lowest release containing this commit;
google/certificate-transparency-go@8af4dd8

The `google.golang.org/genproto/googleapis/api` package was moved to a separate
module in `google.golang.org/genproto@v0.0.0-20230525234044-86246a831fb4`.

Attempting to use older versions could result in ambiguous import errors,
because `google.golang.org/genproto` still contained the package, causing
a duplicate;

    go list ./...
    ../../../../../pkg/mod/google.golang.org/grpc@v1.79.3/status/status.go:35:2: ambiguous import: found package google.golang.org/genproto/googleapis/rpc/status in multiple modules:
        google.golang.org/genproto v0.0.0-20220706185917-7780775163c4 (/Users/thajeztah/go/pkg/mod/google.golang.org/genproto@v0.0.0-20220706185917-7780775163c4/googleapis/rpc/status)
        google.golang.org/genproto/googleapis/rpc v0.0.0-20251202230838-ff82c1b0f217 (/Users/thajeztah/go/pkg/mod/google.golang.org/genproto/googleapis/rpc@v0.0.0-20251202230838-ff82c1b0f217/status)
    ../../../../../pkg/mod/go.etcd.io/etcd/api/v3@v3.6.5/etcdserverpb/rpc.pb.go:19:2: ambiguous import: found package google.golang.org/genproto/googleapis/api/annotations in multiple modules:
        google.golang.org/genproto v0.0.0-20220706185917-7780775163c4 (/Users/thajeztah/go/pkg/mod/google.golang.org/genproto@v0.0.0-20220706185917-7780775163c4/googleapis/api/annotations)
        google.golang.org/genproto/googleapis/api v0.0.0-20251202230838-ff82c1b0f217 (/Users/thajeztah/go/pkg/mod/google.golang.org/genproto/googleapis/api@v0.0.0-20251202230838-ff82c1b0f217/annotations)
    github.com/moby/swarmkit/swarmd/cmd/external-ca-example

Updating `github.com/google/certificate-transparency-go` updates the minimum
version of `google.golang.org/genproto`, preventing the problem.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah mentioned this pull request Aug 1, 2026
1 task
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 14.69%. Comparing base (6e9e7b8) to head (583e171).
⚠️ Report is 60 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3279      +/-   ##
==========================================
- Coverage   14.73%   14.69%   -0.04%     
==========================================
  Files         200      200              
  Lines       93077    93027      -50     
==========================================
- Hits        13712    13668      -44     
+ Misses      78019    78014       -5     
+ Partials     1346     1345       -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants