manager/csi: add missing nil check in PublishVolume, UnpublishVolume - #3277
Open
thaJeztah wants to merge 1 commit into
Open
manager/csi: add missing nil check in PublishVolume, UnpublishVolume#3277thaJeztah wants to merge 1 commit into
nil check in PublishVolume, UnpublishVolume#3277thaJeztah wants to merge 1 commit into
Conversation
Both makeControllerPublishVolumeRequest and makeControllerUnpublishVolumeRequest
check if the `VolumeInfo` is `nil`, in which case they would produce a `nil`
request;
func (p *plugin) makeControllerPublishVolumeRequest(v *api.Volume, nodeID string) *csi.ControllerPublishVolumeRequest {
if v.VolumeInfo == nil {
return nil
}
...
func (p *plugin) makeControllerUnpublishVolumeRequest(v *api.Volume, nodeID string) *csi.ControllerUnpublishVolumeRequest {
if v.VolumeInfo == nil {
return nil
}
...
This request which would be sent to the CSI controller-client, potentially
resulting in an obscure error during marshaling;
rpc error: code = Internal desc = grpc: error while marshaling: proto: Marshal called with nil
Update `PublishVolume` and `UnpublishVolume` to return early, similar to the
existing check in `DeleteVolume`;
func (p *plugin) DeleteVolume(ctx context.Context, v *api.Volume) error {
if v.VolumeInfo == nil {
return errors.New("VolumeInfo must not be nil")
}
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3277 +/- ##
=======================================
Coverage 14.73% 14.73%
=======================================
Files 200 200
Lines 93077 93025 -52
=======================================
- Hits 13712 13711 -1
+ Misses 78019 77968 -51
Partials 1346 1346 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both makeControllerPublishVolumeRequest and makeControllerUnpublishVolumeRequest check if the
VolumeInfoisnil, in which case they would produce anilrequest;This request which would be sent to the CSI controller-client, potentially resulting in an obscure error during marshaling;
Update
PublishVolumeandUnpublishVolumeto return early, similar to the existing check inDeleteVolume;- What I did
- How I did it
- How to test it
- Description for the changelog