manager: ListWALs: remove redundant sort, and skip directories - #3275
Open
thaJeztah wants to merge 1 commit into
Open
manager: ListWALs: remove redundant sort, and skip directories#3275thaJeztah wants to merge 1 commit into
thaJeztah wants to merge 1 commit into
Conversation
os.ReadDir already returns a sorted list;
// ReadDir reads the named directory,
// returning all its directory entries sorted by filename.
Remove the manual sort, and while updating, also skip directories,
because we're looking for files.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3275 +/- ##
==========================================
- Coverage 14.73% 14.69% -0.04%
==========================================
Files 200 200
Lines 93077 93028 -49
==========================================
- Hits 13712 13670 -42
- Misses 78019 78027 +8
+ Partials 1346 1331 -15 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR simplifies WAL discovery in the raft storage layer by relying on os.ReadDir’s documented sorted output and by ignoring directory entries when collecting WAL filenames.
Changes:
- Removed the redundant explicit sort of WAL filenames in
ListWALs. - Skipped directory entries when scanning for
*.walfiles.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
os.ReadDir already returns a sorted list;
Remove the manual sort, and while updating, also skip directories, because we're looking for files.
- What I did
- How I did it
- How to test it
- Description for the changelog