agent/csi,manager/csi: roll back client initialization on failure - #3254
Open
thaJeztah wants to merge 1 commit into
Open
agent/csi,manager/csi: roll back client initialization on failure#3254thaJeztah wants to merge 1 commit into
thaJeztah wants to merge 1 commit into
Conversation
The CSI plugins publish their gRPC clients before initialization completes because init() uses the client accessors during capability discovery. If initialization fails, the plugin is left partially initialized and subsequent calls reuse stale clients instead of retrying initialization. Close the gRPC connection and reset the published clients when init() fails so the plugin returns to its pre-connect state and a later attempt can retry cleanly. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3254 +/- ##
==========================================
+ Coverage 14.73% 14.75% +0.01%
==========================================
Files 200 200
Lines 93077 93102 +25
==========================================
+ Hits 13712 13733 +21
- Misses 78019 78035 +16
+ Partials 1346 1334 -12 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CSI plugins publish their gRPC clients before initialization completes because init() uses the client accessors during capability discovery. If initialization fails, the plugin is left partially initialized and subsequent calls reuse stale clients instead of retrying initialization.
Close the gRPC connection and reset the published clients when init() fails so the plugin returns to its pre-connect state and a later attempt can retry cleanly.
- What I did
- How I did it
- How to test it
- Description for the changelog