Conversation
vvoland
commented
Sep 16, 2026
vvoland
commented
Collaborator
- fix: Please add a License #2
thaJeztah
requested changes
Sep 17, 2026
Comment on lines
+1
to
+2
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
Member
There was a problem hiding this comment.
This also needs a copyright; we can use the same as we did for moby/profiles;
// SPDX-FileCopyrightText: Copyright The Moby Authors
// SPDX-License-Identifier: Apache-2.0
Collaborator
Author
There was a problem hiding this comment.
Ah good point, done
Comment on lines
+6
to
+18
| cd "$(dirname "${BASH_SOURCE[0]}")/.." | ||
|
|
||
| # Check tracked sources only; vendored code keeps its upstream licensing. | ||
| git ls-files -z -- '*.go' '*.sh' '*.proto' ':!:vendor/**' | ( | ||
| status=0 | ||
| while IFS= read -r -d '' path; do | ||
| if ! sed -n '1,5p' "$path" | grep -Eq '^(//|#) SPDX-License-Identifier: Apache-2\.0[[:space:]]*$'; then | ||
| printf '%s: missing Apache-2.0 SPDX header in the first five lines\n' "$path" >&2 | ||
| status=1 | ||
| fi | ||
| done | ||
| exit "$status" | ||
| ) |
Member
There was a problem hiding this comment.
FWIW, we could use the go-header linter for this; https://golangci-lint.run/docs/linters/configuration/#goheader
But not sure if it also handles non-Go files, so alternatively https://github.com/containerd/ltag our https://github.com/google/addlicense
Not really a concern right now, but if we'd ever fork code from other modules (or, e.g. from stdlib), we can't assume all files to have Apache 2.0.
Collaborator
Author
There was a problem hiding this comment.
We can change that later 😅
vvoland
force-pushed
the
add-license
branch
from
September 17, 2026 13:12
2df951d to
e419609
Compare
Signed-off-by: Paweł Gronowski <git@grono.dev>
Signed-off-by: Paweł Gronowski <git@grono.dev>
vvoland
force-pushed
the
add-license
branch
from
September 17, 2026 13:13
e419609 to
587697f
Compare
Signed-off-by: Paweł Gronowski <git@grono.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.