Skip to content

fix: use openssl instead of security cms#182

Merged
gmegidish merged 1 commit intomainfrom
fix-use-openssl-instead-of-security-cms
Mar 3, 2026
Merged

fix: use openssl instead of security cms#182
gmegidish merged 1 commit intomainfrom
fix-use-openssl-instead-of-security-cms

Conversation

@gmegidish
Copy link
Member

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Mar 3, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 9b5cb7e and d7b0f5f.

📒 Files selected for processing (1)
  • utils/resign.go

Walkthrough

The change modifies the provisioning profile decoding mechanism in utils/resign.go. The existing implementation uses the macOS security tool command (security cms -D -i profilePath) to decode provisioning profiles. This is replaced with an OpenSSL command (openssl smime -inform DER -verify -noverify -in profilePath). The surrounding code structure, including the parsing of the plist and return logic, remains unchanged. Error handling and control flow are preserved with this substitution.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-use-openssl-instead-of-security-cms

Comment @coderabbitai help to get the list of available commands and usage tips.

@gmegidish gmegidish merged commit 5eff5df into main Mar 3, 2026
6 of 7 checks passed
@gmegidish gmegidish deleted the fix-use-openssl-instead-of-security-cms branch March 3, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant