Skip to content

Vertexselect source index renaming #14154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gnefil wants to merge 11 commits into
base: main
Choose a base branch
from
+2 −2
Open

Vertexselect source index renaming #14154

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
44111b4
ENH: Add extra source id parameter to vertex select
Gnefil Jul 28, 2026
1ee2216
ENH: Simplify argmax selection with non-zero guard
Gnefil Aug 4, 2026
8b84360
Apply suggestions from code review
Gnefil Aug 7, 2026
9624128
[autofix.ci] apply automated fixes
autofix-ci[bot] Aug 7, 2026
6212a64
ENH: Clean extra line
Gnefil Aug 7, 2026
1b10afb
DOC: Add changelog
Gnefil Aug 7, 2026
1563bc1
ENH: Add None option for source_id parameter
Gnefil Aug 8, 2026
15f459a
ENH: Add test for the new functionality
Gnefil Aug 8, 2026
00d169a
Merge branch 'main' into vertexselect-source-index
wmvanvliet Aug 11, 2026
f918a32
ENH: Remove variable renaming
Gnefil Aug 12, 2026
604ae97
Merge branch 'main' into vertexselect-source-index
wmvanvliet Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mne/viz/_brain/_brain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1476,8 +1476,8 @@ def _on_pick(self, vtk_picker, event):
# dists = dists - dists.min()
# dists = (1. - dists / dists.max()) * self._cmap_range[1]
# grid.point_data['values'][vertices] = dists * mask
idx = idx[np.argmax(np.abs(scalars[idx]))]
vertex_id = vertices[idx]
source_id = idx[np.argmax(np.abs(scalars[idx]))]
vertex_id = vertices[source_id]
# Naive way: convert pos directly to idx; i.e., apply mri_src_t
# shape = self._data[hemi]['grid_shape']
# taking into account the cell vs point difference (spacing/2)
Expand Down
Loading