ENH: expose font_file in Brain.add_text#13778
ENH: expose font_file in Brain.add_text#13778PragnyaKhandelwal wants to merge 7 commits intomne-tools:mainfrom
Conversation
wmvanvliet
left a comment
There was a problem hiding this comment.
Really nice work! It would be nice to also test setting font_file as part of one of the unit tests.
|
Thanks for the review @wmvanvliet . I updated the backend to always pass |
|
I verified the checks failed....looks like the |
|
Hi @wmvanvliet and @drammock, just a quick note that I've addressed the feedback regarding the font discovery logic and documentation clarifications. |
|
One comment left unaddressed. Why are you using a |
Well good catch, @wmvanvliet. I’ve switched from |
|
At this point, only ci/circleci: build_docs is failing (looks like a CI timeout during docs build), while the other checks are passing. Could you please re-run that job when convenient? |
actually, I suspect it was a network error; looks like the |
Co-authored-by: Daniel McCloy <dan@mccloy.info>
|
@wmvanvliet this LGTM. I've enabled auto-merge but IDK if it will actually work since you have a "request changes" review. Can you look again and approve if happy? (or, wait and see what automerge does in this case!) |
OK, it's not transient. Probably the objects.inv has moved. Will need to investigate. |
|
Could it be this, ~73% reliability lately? |
could be. Intersphinx registry has the correct URL, and I am able to download it manually. |
Reference issue (if any)
Fixes #12543.
What does this implement/fix?
This PR exposes a
font_fileparameter inbrain.add_text()and forwards it to the underlying PyVistaadd_text()call.This allows users to pass a
.ttf/.ttcfont file for Unicode glyph rendering (for example, CJK characters and symbols), while preserving current behavior whenfont_fileis not provided.Additional information
Verification context:
font_filein PyVista resolves Unicode rendering foradd_text().