FIX: Improve channel name rendering in plot_alignment#13773
Open
aman-coder03 wants to merge 5 commits intomne-tools:mainfrom
Open
FIX: Improve channel name rendering in plot_alignment#13773aman-coder03 wants to merge 5 commits intomne-tools:mainfrom
plot_alignment#13773aman-coder03 wants to merge 5 commits intomne-tools:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
Fixes #13772
What does this implement/fix?
The
show_channel_namesfeature added in #13570 had a few rendering issues,scale=0.005was too large, causing labels to appear huge and overlap each other badly(1.0, 1.0, 1.0)which is hard to read against the pale scalp surfacethis reduces the scale to
0.0015, switches to black text for better contrast, and adds a small outward offset to push each label away from the head surface in the direction away from the centroidAdditional information
tested locally on Windows with the sample dataset using
eeg_on_scalp.py. the labels are now readable and reasonably sized. some overlap is still expected with dense electrode layouts (59 EEG channels) but that would require a full label placement algorithm and is out of scope for this fix