feat(polhemus): add resetRegistration() to PolhemusCoregistration#996
Open
chdinh wants to merge 1 commit into
Open
feat(polhemus): add resetRegistration() to PolhemusCoregistration#996chdinh wants to merge 1 commit into
chdinh wants to merge 1 commit into
Conversation
Clears headToWorld, headToDevice and sets registrationValid=false, then emits registrationChanged. Called when the user clears all acquired points so no stale transform remains active.
There was a problem hiding this comment.
Pull request overview
This PR adds a small public API to clear any previously computed Polhemus head↔device registration, ensuring downstream consumers don’t keep using a stale transform after fiducials/points are cleared.
Changes:
- Added
PolhemusCoregistration::resetRegistration()declaration to the public interface. - Implemented
resetRegistration()to invalidate registration, reset transforms to identity, and emitregistrationChanged().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/libraries/utils/polhemus/polhemus_coregistration.h | Adds the resetRegistration() public method declaration and Doxygen comment. |
| src/libraries/utils/polhemus/polhemus_coregistration.cpp | Implements resetRegistration() to clear registration state and notify listeners. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+168
to
+169
| * @brief Reset the registration state (headToWorld, headToDevice) to identity. | ||
| * Call this when the user clears all fiducials. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears headToWorld, headToDevice and sets registrationValid=false, then emits registrationChanged. Called when the user clears all acquired points so no stale transform remains active.