Repository navigation
Judge three more rules by a drained monster's Hit Dice, and give death spell its cube - #194
Merged
Merged
Conversation
Pin that a drained monster's remaining Hit Dice decide confusion's re-save, the protection-scroll ward bands, and the 5 HD optional rule. Guards pin that the turning column stays with the monster type. Pin that a group-aimed hd_budget spell with an area, like death spell's 60' cube, takes only the candidates its area would take. Guards pin that sleep still takes every living member and that named targets win. The eight acceptance tests are marked xfail for chunk drain-and-area. The adaptations register and the public docstrings state the new rules. Claude-Session: https://claude.ai/code/session_01V7ErtnsmhaP7aLwcfmzohD
…oup aim to its cube The confusion re-save, the protection-scroll Hit Dice bands, and the 5 HD counts-as-magical check now read MonsterInstance.hit_dice_count instead of the template. A death spell aimed at a group with target_group_id now takes only the candidates its 60' cube would take, through _area_candidates. Sleep is unchanged. No golden file changed. Claude-Session: https://claude.ai/code/session_01V7ErtnsmhaP7aLwcfmzohD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two rules gaps I found during the backlog work.
Drained Hit Dice
Energy drain lowers a monster's Hit Dice, and #188 made sleep use the Hit Dice the monster has left. Three more rules now use that count,
MonsterInstance.hit_dice_count, instead of the template's:The wight page says a drain removes "all other benefits due to the drained level". The turning column and experience value still use the template, because the SRD ties them to the kind of monster ("the HD of the type of undead monsters targeted", and a stat block's pre-calculated XP).
Death spell aimed at a group
An
hd_budgetspell aimed at a group withtarget_group_idtook every living member of the group. That's right for sleep, which has no area, but death spell has a 60' cube. A group-aimedhd_budgetspell with an area now takes the same candidates_area_candidatesgives an area spell. Withaoe_friendly_fireon at melee range, that includes the engaged front rank, as with fire ball.What to check
check_immunityreadshit_dice_countthroughgetattr, because theCreatureprotocol it takes doesn't declare that attribute.https://claude.ai/code/session_01V7ErtnsmhaP7aLwcfmzohD