Add sum_scatter to the ring backend - #4236
Open
erwinzhang7 wants to merge 1 commit into
Open
Conversation
erwinzhang7
force-pushed
the
ring-sum-scatter
branch
from
August 16, 2026 01:44
43af86d to
706bb43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part of #4285.
all_reduce_implalready runs its send/recv plan twice, and the code says why:"Two times the same send/recv operations, first scatter reduce and then gather."
The
k == 0half is a reduce-scatter, so sum_scatter is that phase with the localsegment kept instead of continuing into the gather.
Verified on two M4 Pro minis over a direct Thunderbolt link: the call returns
cleanly on both ranks where current main hangs indefinitely, and the ring
distributed test suite gains a sum_scatter case.
Note that this does not address the second half of the issue. An error raised out of
ReduceScatter::eval_cpustill does not reach the caller; this change means thecommon path no longer raises at all.