Fix load_weights with strict=False to filter extra weights before update#3214
Merged
angeloskath merged 3 commits intoml-explore:mainfrom Mar 10, 2026
Merged
Conversation
added 3 commits
March 6, 2026 09:49
… the weights dict prunes out the unused weight keys to avoid idx error during tree_unflatten
… of bounds, and if so we ignore it on strict=False
angeloskath
approved these changes
Mar 6, 2026
Member
angeloskath
left a comment
There was a problem hiding this comment.
Thanks for the catch and fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
When loading weights from a checkpoint that contains more layers than the model (e.g., loading a full
model's safetensors into a model instantiated with
num_hidden_layers=1),load_weights(..., strict=False)raises an
IndexError: list index out of range. This happens because indexed keys likelayers.1.weightpass through
tree_unflattenandModule.updatetries to index into the model's layers list at positionsthat don't exist.
This restores the filtering of weight keys to only those present in the model's parameters when
strict=False, so extra weights are silently dropped before reaching update.Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes