Conversation
mkobetic
commented
Mar 18, 2026
| @@ -1,32 +1,4 @@ | |||
| # SPDX-License-Identifier: GPL-3.0-only | |||
|
|
|||
Owner
Author
There was a problem hiding this comment.
I want to separate the lstack words from leave so that it is set up for potential native implementations of those.
11df22c to
cda6f38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leave stack is only used during word compilation. It seems wasteful to have a chunk of RAM just sitting there mostly unused.
This PR adds 6 words for the leave stack to match what's available for return stack, to make it similarly usable for stashing values temporarily. Given that it's only used for compilation, it has fewer restrictions as a value stash than the return stack (e.g. no issue with loops).
However it will be somewhat slower since we do not have a register permanently allocated for it and the words are implemented in ITC (for now). It would be quite feasible to speed things up a bit with native words, if desired.