fix: Preserve nested tuple parentheses - #487
Merged
Merged
Conversation
lprnmns
marked this pull request as ready for review
September 1, 2026 05:54
pawamoy
approved these changes
Sep 1, 2026
pawamoy
left a comment
Member
There was a problem hiding this comment.
Thanks! Found a simplification 🙂 Let me know what you think.
Contributor
Author
|
The simplification looks good to me and keeps the context behavior covered. Thanks for the fixup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For reviewers
Description of the change
Keep tuple-context flags local to the immediate AST node. Previously, a subscript or comprehension-target flag could flow through a nested list, call, or comprehension and remove tuple parentheses below it. This changed the rendered AST in cases such as
o[f((x, y))]and could produce invalid Python for a tuple-valued comprehension nested in a subscript.Four round-trip regressions cover nested containers, calls, comprehensions, and destructuring targets.
Validation:
PYTHON_VERSIONS='' ./scripts/make format check test— passedRelevant resources
main; no issue was required to reproduce it.