Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
thx claude
we got like 20k lines of errors lol
- comment out set/frozenset overloads in json_serialize.py that caused overlapping overload errors (functionality unchanged, just type hints) - add pyright: ignore comments for false positives across source and tests - initialize variable before try block in serializable_dataclass.py - add ty: ignore comments for ty type checker in test files - normalize whitespace before pyright ignore comments
- Rename `path` parameter to `collection_path` in pytest_ignore_collect hook to use the modern pytest API (py.path.local deprecated in pytest 9) - Rename generic `result` variables in test_json_serialize.py to more descriptive names
The Interval class only supports list and tuple for single-arg initialization, not range objects. The test was invalid.
typing.get_type_hints() evaluates forward refs at runtime, so tuple[int, int] fails in Python 3.8 even with future annotations.
- Replace verbose module descriptions with a compact table (26 modules) - Add 16 previously undocumented modules: interval, errormode, validate_type, console_unicode, spinner, timeit_fancy, dbg, collect_warnings, parallel, math, cli, web, logger, mlutils, tensor_info, ml - Use absolute docs links (miv.name/muutils) that work on GitHub, PyPI, and locally - Document all optional dependency groups: array, notebook, parallel, web - Remove separate ZANJ section (external project, now linked from json_serialize)
- CI: split typing step into two - normal check for 3.9+, non-blocking for 3.8 (log only). Also removes 3.14 exclusion. - makefile: only pass TYPECHECK_ARGS (mypy-specific flags like --disable-error-code) to mypy, not to ty/basedpyright
Legacy test matrix uses numpy 1.24.4 which is incompatible with current pandas version, so we force an old once
- Add pandas 2.0.3 pin (compatible with numpy 1.24.4) - Add pillow 10.4.0 pin (avoids deprecation warning in newer versions) - Consolidate numpy/pandas/pillow installs into single legacy step
This module is dynamically generated by PyTorch and has no source file, causing "No source for code" errors when running coverage reports.
matplotlib's PDF backend triggers a Pillow deprecation warning about the 'mode' parameter. Filter this third-party warning only on 3.9.
Add `from __future__ import annotations` to files using `X | Y` union syntax. This enables PEP 563 postponed evaluation, fixing basedpyright errors on Python <3.10.
ty incorrectly infers argument types for pytest.fail() and pytest.skip() due to pytest's internal @_with_exception decorator on Python 3.9 and below.
- Add explicit import of torch.backends.mps to fix possibly-missing-attribute warnings - Add invalid-argument-type to ty ignore comments for pytest.fail/skip calls (arg-type is unknown to ty on Python 3.10, invalid-argument-type is the correct rule name)
The ty type checker reports `too-many-positional-arguments` for pytest.skip() calls on Python <= 3.9. Add this error code to the existing ignore comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.