chore: bump helmich/schema2class to ^4.0.0 - #8
Merged
Merged
Conversation
Fixes invalid PHP generated for property names containing dots, such as the "contract.interactionRequired" query parameter of extension-list-extension-instances. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
martin-helmich
marked this pull request as ready for review
September 24, 2026 13:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generation currently produces invalid PHP in
ExtensionListExtensionInstancesRequest. The API has a query parameter namedcontract.interactionRequired, and schema2class used that name verbatim as a PHP identifier (private ?bool $contract.interactionRequired).schema2class v4.0.0 includes martin-helmich/php-schema2class#145, which treats dots as word separators. The property is now generated as
$contractInteractionRequired, and the JSON/query key stays unchanged.🤖 Generated with Claude Code