Add Identity Controls + ADM Validation Bypasses Dashboard#876
Open
seansica wants to merge 2 commits into
Open
Conversation
Add identity view routing and editor handling for identity-specific fields. Expose MITRE identity write configuration in organization settings and improve protected identity flows.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## next #876 +/- ##
==========================================
- Coverage 31.27% 31.13% -0.14%
==========================================
Files 181 181
Lines 18979 19168 +189
Branches 247 257 +10
==========================================
+ Hits 5935 5968 +33
- Misses 13044 13200 +156 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is now a new button to semi-permanently ignore/hide the reminder modal to edit the placeholder identity:
When you click No, and stop reminding me, the frontend stores a key in localStorage to remember the user's preference.
(I felt that a stateful user-specific config in the database would be overkill).
If you click Yes, edit my identity now, the user is redirected to the edit view for the placeholder identity, as opposed to the
/org-settingssection. This will make sense why in a moment.The global organization identity is now a drop-down selector!
Identities are now first-class objects in Workbench. They can be viewed, created, edited, and deleted, just like any other STIX object.
By default, the MITRE identity is protected. Workbench blocks access to the
?editing=trueview, and the REST API will reject all POST, PUT, and DELETE requests on the MITRE identity specifically.Protecting the MITRE identity can be enabled or disabled using a new endpoint:
The frontend exposes a toggle for this — this toggle/section will only appear on the frontend if the MITRE identity actually exists in the database.
Lastly, the system will block you from deleting an identity if it is the organization identity, or more specifically, if any latest, active objects reference it in their
created_by_reforx_mitre_modified_by_reffields.This endpoint maps to a new key in the
systemconfigurationscollection/entity, calledmitre_identity_writes_enabled.Note that the
organization_identity_refis no longer sticky. Whereas before, it was set to thestix.idof the randomly generatedPlaceholder Organization Identityobject; it can now be changed to a completely different identity using the drop-down selector.Lastly, there is a new dashboard for managing the ADM validation bypass rules:
There is a complementary set of changes on the backend: mitre-attack/attack-workbench-rest-api#481