fix(ci): stop label events from cancelling net-new PR reviews#209
Conversation
Auto-applied labels at PR creation no longer cancel the in-flight opened review (companion to home-ops#7512 / the v1.2.9 label rollout). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![its-saffron[bot]](https://avatars.githubusercontent.com/in/3901073?s=60&v=4){kind=small}
There was a problem hiding this comment.
AI Automated Review
Full PR review.
Analysis engine: dsv4f@https://litellm.jory.dev/v1 (openai) — fallback (primary failed)
Recommendation
Approve. This is a targeted CI fix that prevents auto-applied labels from cancelling the initial PR review. The change is correct, well-documented, and passes all CI checks.
Change-by-Change Findings
Modified: .github/workflows/ai-pr-review.yaml (+3, -1)
- Change: Appends a label-specific suffix (
-label-{run_id}) to the concurrency group key when the triggering event islabeled. This isolates label events from theopened/synchronizegroup, so an auto-applied label (e.g., from Renovate) cannot cancel an in-flightopenedreview.cancel-in-progress: trueremains for all events, which is correct—only the intended cancellation scope is narrowed. - Rationale: The PR body explains the root cause (tracked in home-ops#7507, fixed in home-ops#7512) and the fix aligns with the pattern established in the author's other repository.
Source Verification
The PR body references the upstream root cause and fix. No linked issues in this repository. The logic is self-explanatory from the diff and comment.
Standards Compliance
This change only affects a CI workflow definition. No application code, Godot scenes, or game logic are modified. The repository standards (AGENTS.md) focus on game product direction and UI conventions; none are applicable to this CI change.
Linked Issue Fit
No linked issue was found in the PR body. The change is a direct fix for a CI concurrency problem and does not correspond to a feature or bug ticket in this repository.
Evidence Provider Findings
No evidence providers were configured for this review.
Tool Harness Findings
The tool harness performed no requests (0 planned rounds). No issues detected.
CI Check Results
All three CI checks completed successfully:
- Headless smoke test: success
- Script test suite: success
- macOS validation: success
Unknowns or Needs Verification
None. The change is minimal, isolated, and the intended behavior is clear from the diff and comments.
1 participant
Companion to the v1.2.9 label rollout:
labeledevents shared the concurrency group withcancel-in-progress: true, so an auto-applied label at PR creation could cancel the in-flightopenedreview and leave the PR unreviewed (root-caused on home-ops#7507, fixed there in joryirving/home-ops#7512). This isolateslabeledevents into their own concurrency group. No action change. A non-ai-reviewlabel add still spins a run, but the action's precheck no-ops it (no model call) and it reports success.🤖 Generated with Claude Code