fix(ci): stop label events from cancelling net-new PR reviews#372
Conversation
Auto-applied labels at PR creation no longer cancel the in-flight opened review (companion to home-ops#7512 / the v1.2.9 label rollout). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
AI Automated Review
Full PR review.
Analysis engine: review@https://litellm.jory.dev/v1 (openai) — fast route
Summary
This PR fixes a race condition in the ai-pr-review workflow. Previously, labeled events shared the same concurrency group as the opened event. Because cancel-in-progress was set to true, an automated label addition (e.g., from Renovate) would cancel the initial review run. This change isolates labeled events into their own unique concurrency groups.
Change-by-change findings
.github/workflows/ai-pr-review.yaml: Theconcurrency.groupexpression has been updated to append a unique suffix (-label-<run_id>) when the event action islabeled. This ensures thatlabeledevents do not share a concurrency group with theopenedevent, preventing them from triggeringcancel-in-progressfor the primary review run.
Sources
- PR description
Standards Compliance
The implementation follows standard GitHub Actions syntax and correctly uses github.run_id to ensure uniqueness for the labeled event concurrency group.
Linked Issue Fit
The implementation directly addresses the problem described in the PR body: preventing labeled events from cancelling net-new PR reviews (referencing home-ops#7507 and home-ops#7512).
Companion to the v1.2.9 label rollout:
labeledevents shared the concurrency group withcancel-in-progress: true, so an auto-applied label at PR creation could cancel the in-flightopenedreview and leave the PR unreviewed (root-caused on home-ops#7507, fixed there in joryirving/home-ops#7512). This isolateslabeledevents into their own concurrency group. No action change. A non-ai-reviewlabel add still spins a run, but the action's precheck no-ops it (no model call) and it reports success.🤖 Generated with Claude Code