Skip to content

fix(ci): stop label events from cancelling net-new PR reviews#372

Merged
joryirving merged 1 commit into
mainfrom
fix/label-concurrency-net-new-prs
Jun 13, 2026
Merged

fix(ci): stop label events from cancelling net-new PR reviews#372
joryirving merged 1 commit into
mainfrom
fix/label-concurrency-net-new-prs

Conversation

@joryirving

Copy link
Copy Markdown
Contributor

Companion to the v1.2.9 label rollout: labeled events shared the concurrency group with cancel-in-progress: true, so an auto-applied label at PR creation could cancel the in-flight opened review and leave the PR unreviewed (root-caused on home-ops#7507, fixed there in joryirving/home-ops#7512). This isolates labeled events into their own concurrency group. No action change. A non-ai-review label add still spins a run, but the action's precheck no-ops it (no model call) and it reports success.

🤖 Generated with Claude Code

Auto-applied labels at PR creation no longer cancel the in-flight opened
review (companion to home-ops#7512 / the v1.2.9 label rollout).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@joryirving joryirving merged commit 2eef34d into main Jun 13, 2026
3 checks passed
@joryirving joryirving deleted the fix/label-concurrency-net-new-prs branch June 13, 2026 18:51

@its-saffron its-saffron Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Automated Review

Full PR review.

Analysis engine: review@https://litellm.jory.dev/v1 (openai) — fast route

Summary

This PR fixes a race condition in the ai-pr-review workflow. Previously, labeled events shared the same concurrency group as the opened event. Because cancel-in-progress was set to true, an automated label addition (e.g., from Renovate) would cancel the initial review run. This change isolates labeled events into their own unique concurrency groups.

Change-by-change findings

  • .github/workflows/ai-pr-review.yaml: The concurrency.group expression has been updated to append a unique suffix (-label-<run_id>) when the event action is labeled. This ensures that labeled events do not share a concurrency group with the opened event, preventing them from triggering cancel-in-progress for the primary review run.

Sources

  • PR description

Standards Compliance

The implementation follows standard GitHub Actions syntax and correctly uses github.run_id to ensure uniqueness for the labeled event concurrency group.

Linked Issue Fit

The implementation directly addresses the problem described in the PR body: preventing labeled events from cancelling net-new PR reviews (referencing home-ops#7507 and home-ops#7512).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant