Skip to content

Run tests in localeTest and read bucket quota from size #1720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balamurugana merged 6 commits into from
Sep 17, 2026
+7 −3
Merged

Run tests in localeTest and read bucket quota from size #1720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c85470c
Run unit tests in localeTest task
allanrogerr Sep 15, 2026
be7efdc
Read bucket quota from size field in getBucketQuota
allanrogerr Sep 15, 2026
c07ed92
Show full test failures from every Test task
allanrogerr Sep 16, 2026
30cfe7a
Cover bucket quota response shapes and add a live round trip
allanrogerr Sep 16, 2026
e47827e
Read and write bucket quota as size only
allanrogerr Sep 16, 2026
ff76418
Remove the quota unit and functional tests
allanrogerr Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions adminapi/src/main/java/io/minio/admin/MinioAdminClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,7 @@ public void setBucketQuota(@Nonnull String bucketName, long size, @Nonnull Quota
throws MinioException {
Map<String, Object> quotaEntity = new HashMap<>();
if (size > 0) quotaEntity.put("quotatype", "hard");
quotaEntity.put("quota", unit.toBytes(size));
quotaEntity.put("size", unit.toBytes(size));
try (Response response =
execute(
Http.Method.PUT,
Expand Down Expand Up @@ -471,7 +471,7 @@ public long getBucketQuota(String bucketName) throws MinioException {
.getTypeFactory()
.constructMapType(HashMap.class, String.class, JsonNode.class);
Map<String, JsonNode> quotaEntity = OBJECT_MAPPER.readValue(response.body().bytes(), mapType);
JsonNode quota = quotaEntity.get("quota");
JsonNode quota = quotaEntity.get("size");
if (quota == null) throw new MinioException("quota not found in response");
// JsonNode.asLong() coerces anything non-numeric to zero, making a malformed response
// indistinguishable from a cleared quota; reject such values instead.
Expand Down
6 changes: 5 additions & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ subprojects {
}
}

test {
tasks.withType(Test).configureEach {
// Show stacktrace on test failure than opening in web browser.
testLogging {
exceptionFormat = 'full'
Expand All @@ -101,6 +101,10 @@ subprojects {

tasks.register('localeTest', Test) {
description = 'Runs tests with locale de-DE'
// A Test task registered this way has no test classes of its own; without these two
// lines it reports NO-SOURCE and runs nothing.
testClassesDirs = sourceSets.test.output.classesDirs
classpath = sourceSets.test.runtimeClasspath
Comment thread
balamurugana marked this conversation as resolved.
systemProperty 'user.language', 'de'
systemProperty 'user.country', 'DE'
}
Expand Down
Loading