ci(java): retry JDK 10 test suite once on transient fork startup crash - #198
Merged
Merged
Conversation
Zulu 10.0.2's forked test JVM intermittently crashes while starting on ubuntu-22.04 runners (surefire reports "The forked VM terminated without properly saying goodbye" with zero tests run). The failure reproduces on neither a rerun nor any other matrix entry and happens before any test class loads, so retry the suite once before failing the step.
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe JDK 10 GitHub Actions test step now retries Maven verification once after failure. It exits immediately after success and returns the final failure status when both attempts fail. ChangesJDK 10 CI execution
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Java CI's JDK 10 matrix entry failed on main (run 35563074234): the forked test JVM (Zulu 10.0.2) terminated at startup with exit code 1 and zero tests run ("The forked VM terminated without properly saying goodbye. VM crash or System.exit called?").
Analysis
Conclusion: an intermittent native startup crash of the ancient Zulu 10.0.2 forked JVM on ubuntu-22.04 runners.
Change
Retry the JDK 10 verify once before failing the step, with a warning logged between attempts, so a transient fork crash does not fail CI.
Summary by CodeRabbit