Repository navigation
required-registration-fields 2.0.2: tested up to Shopclass 7.1 - #30
Merged
Merged
Conversation
Package validationAutomated checks against
|
| Gate | Result |
|---|---|
| Gate | Status |
| --- | --- |
| Structure, manifest & security | ✅ |
| Deprecated API | |
| Smoke install | ✅ |
2. Manifest (shopclass.json schema) |
✅ 0 error(s), 0 warning(s) |
5. Parse (php -l, 8.0–8.5) |
✅ 0 failure(s) across 6 PHP version(s) |
| 6. PHP 8.0 floor (PHPCompatibility) | ✅ 0 error(s), 0 warning(s) |
| 10. Style (PSR-12) — warning only |
Package CI — required-registration-fields
Errors
None.
Warnings — not blocking
These do not gate anything. A pull request may be merged with warnings outstanding — they exist to inform, not to reject.
index.php:158—Preference::newInstanceis deprecated since 7.0.0, with no scheduled removal version yet. UsegetInstance()instead.index.php:248—User::newInstanceis deprecated since 7.0.0, with no scheduled removal version yet. UsegetInstance()instead.
Updated for commit 21e287b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installed from Browse on Shopclass 7.1, saved its settings, and checked sign-up: an empty required field is refused on the server, and a full sign-up saves every field.