Repository navigation
feat(schemas): bundled semantic rules with evals - #233
Open
mindsocket wants to merge 5 commits into
Open
mindsocket wants to merge 5 commits into
mindsocket wants to merge 5 commits into
Conversation
Type descriptions for strict_ost (from Continuous Discovery Habits) and strategy_general, and semantic rules on all four bundled schemas: - strict_ost: outcome-product-outcome, opportunity-refines-parent, opportunities-distinct, solution-addresses-opportunity, solution-serves-outcome, assumption-category-fits - strategy_general: goals-distinct, goals-cover-parent, goal-advances-parent, opportunity-serves-ancestors, problem-statement-names-no-solution - knowledge_wiki: concept-or-entity, synthesis-connects - okf: okf-description-informative Each rule has an eval with near-misses and contrast pairs; rules that judge children get one small tree per scenario. The judge now gets a type's description when its oneOf entry is a $ref (strategy_general, knowledge_wiki). Base fields whose description only restated the name (title, summary, tags) drop theirs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019XphpcQHEAB9KwJ5Ltiomb
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
- Merge the duplicate verdict into overlapping on opportunities-distinct and goals-distinct: every provider confused the two, and they shared a severity. - Rubrics for the parent-fit rules, assumption-category-fits and okf-description-informative, so a related or reworded node no longer passes. - Narrow traction-metric to the use of one named feature, so behaviour in one flow stays a product outcome. - Fix labels and scenarios that the stronger providers rightly disputed, and drop cases with no clear answer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019XphpcQHEAB9KwJ5Ltiomb
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019XphpcQHEAB9KwJ5Ltiomb
Drop the financial independence goals-distinct case, whose label was arguable. Reword two OST fixture nodes so the intended verdict is clear, accept either non-pass verdict for the Kindle goal, and say in the weak-link description that restating the parent counts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019XphpcQHEAB9KwJ5Ltiomb
3 of 4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Rog · project thread
Slice 3 of reusable semantic rules: the primitives as plain rules, plus rules researched for each bundled schema, each with an eval in the #228 harness.
Rules
outcome-product-outcomeopportunity-refines-parentopportunities-distinctsolution-addresses-opportunitysolution-serves-outcomeassumption-category-fitsgoals-distinctopportunities-distinctgoals-cover-parentgoal-advances-parentopportunity-serves-ancestorsproblem-statement-names-no-solutionconcept-or-entitysynthesis-connectsokf-description-informativeSet-level rules sit on the parent with a
whenthat needs two or more children of the type, so they cost one call per such parent. No verdict reportserror, so none gate.Sources. strict_ost type descriptions, rule wording and the assumption categories follow Torres: Continuous Discovery Habits and producttalk.org (opportunity mapping: "a child opportunity … is a subset of a parent opportunity", siblings are "distinct—you can address one without addressing another"; defining product outcomes: business vs product outcomes, traction metrics, outputs in outcome language). strategy_general has no single source, so its descriptions are plain definitions of vision, mission and goal; collectively exhaustive is from MECE (Minto) and complete refinement (KAOS), as in the plan doc.
Evals
14 new evals, 247 cases, 15 to 20 per rule. About a third are near-misses or mixed framings, with a comment on each: an output worded as an outcome, a solution that addresses its opportunity but works against the outcome (a daily email digest that keeps people out of the product), "the lack of a solution" worded as a problem, a named method that is still a concept. Scenarios come in contrast pairs where one detail flips the label.
Four new fixtures in
fixtures.json5:ost-trees,strategy-trees,knowledge-wiki,okf. Children-scope rules get one small tree per scenario. Parent- and ancestor-scope rules share parents, since their input holds no siblings. A few labels accept two verdicts where both are defensible;--checkpasses on all.Not run live yet: the container has no provider keys. To run on your MacBook:
Other changes
descriptionwhen itsoneOfentry is a$ref. Before, strategy_general and knowledge_wiki sent no type descriptions at all.title,summaryandtagsno longer have descriptions that only restate their names ("Short summary"), so they drop out ofitem_types. Their values still reach the judge.parentkeeps "Parent node", because otherwise the wikilink def's "An Obsidian wikilink, e.g. [[Parent Node]]" shows instead.semantic-rules.md, a line inschemas.md, and a pointer inschema-authoring.md.Out of scope: rule templates (slice 4, which needs your agreement on the dialect), and harder cases for the existing
opportunity-customer-voiceeval.Generated by Claude Code