Repository navigation
feat: type validation issue kinds as ValidationIssueKind - #214
Merged
Merged
Conversation
FileValidationIssue.kind was a string. VALIDATION_ISSUE_KINDS lists the kinds at runtime and ValidationIssueKind derives from it, so consumers such as map-views can build enums from it instead of restating the list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019XphpfuisYsa8kb3fSwLCX
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Rog · project thread
What
FileValidationIssue.kindwasstring. It is nowValidationIssueKind, derived from a runtimeas constarray:Why
map-views (PR mindsocket/structured-context-map-views#30) needs the kinds at runtime for the JSON Schema enum on
nodes.validationSources. Exporting the array lets it import the list instead of restating it asANNOTATION_SOURCES.Public surface (agreed in the project thread)
structured-context/types:VALIDATION_ISSUE_KINDS,ValidationIssueKind(viasrc/types.ts, which imports no runtime code, so it is browser-safe).structured-context/api: re-exports both.The plugin's
state.tskeepskind: string, since it adds its ownparsekind.Checks
bun run typecheck,bun run lint,bun run test(901 pass, 0 fail).Generated by Claude Code