Skip to content

🔧 add husky and license check - #435

Open
sebastianMindee wants to merge 4 commits into
mainfrom
add-husky-and-license-check
Open

🔧 add husky and license check#435
sebastianMindee wants to merge 4 commits into
mainfrom
add-husky-and-license-check

Conversation

@sebastianMindee

Copy link
Copy Markdown
Collaborator

Description

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The pre-commit format task currently runs with --no-restore before any restore occurs, and the license-check script should fail fast with a clearer message when dotnet-delice isn’t available.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR introduces local Git hooks via Husky.Net and adds an automated dependency license whitelist check, aligning local developer workflows with the repository’s CI checks.

Changes:

  • Add Husky.Net hook entrypoints and task-runner configuration for pre-commit (format/build) and pre-push (license check/unit tests).
  • Add a dotnet-delice-based license whitelist check and run it in CI static analysis.
  • Add a local tool manifest (.config/dotnet-tools.json) and ignore dotnet-delice’s generated licenses.json.
File summaries
File Description
.husky/task-runner.json Defines Husky.Net tasks for formatting, build, license checking, and unit tests.
.husky/run-unit-tests.sh Runs unit tests across supported TFMs depending on OS.
.husky/pre-push Husky hook entrypoint to run the pre-push task group.
.husky/pre-commit Husky hook entrypoint to run the pre-commit task group.
.husky/licenses.allowed-packages Per-package allowlist exceptions for license detection gaps.
.husky/licenses.allowed Allowlist of accepted license expressions.
.husky/check-licenses.sh Implements the dotnet delice + whitelist license enforcement.
.gitignore Ignores generated licenses.json output from dotnet-delice.
.github/workflows/_static-analysis.yml Restores local tools and runs the license check in CI.
.config/dotnet-tools.json Adds local tool definitions (husky, dotnet-delice, mindee CLI).
Review details
  • Files reviewed: 9/10 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .husky/task-runner.json Outdated
Comment thread .husky/check-licenses.sh
sebastianMindee and others added 3 commits September 3, 2026 18:00
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants