fix: correct xunit v3 migration instructions for CI compatibility#16
Draft
bschatzmbo wants to merge 1 commit into
Draft
fix: correct xunit v3 migration instructions for CI compatibility#16bschatzmbo wants to merge 1 commit into
bschatzmbo wants to merge 1 commit into
Conversation
- Remove incorrect guidance to keep Microsoft.NET.Test.Sdk and xunit.runner.visualstudio (neither works with xunit v3) - Replace `dotnet test` validation with `dotnet run --project` - Add CI integration section covering coverlet --targetargs= quoting, full tool paths, and .trx file verification - Update main prompt validation step to distinguish v2/v3 test runners Learned from Mindbody.Infrastructure.AuditLogging upgrade where the gated build silently produced 0 tests due to coverlet argument parsing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Microsoft.NET.Test.Sdkandxunit.runner.visualstudio(neither works with xunit v3)dotnet testvalidation withdotnet run --projectfor xunit v3 projects--targetargs=quoting, full tool paths, and.trxfile verificationContext
Learned from Mindbody.Infrastructure.AuditLogging upgrade where the gated build silently produced 0 tests due to coverlet's System.CommandLine parser misinterpreting
--targetargs "-trx ..."as-t rx(the-tshort option for--target).Test plan
--targetargs=syntax runs all tests and produces.trxfile🤖 Generated with Claude Code