Conversation
| config.password = password | ||
| end | ||
|
|
||
| expect(DocumentCloud.client.instance_variable_get(:@email)).to eq CGI.escape(email) |
There was a problem hiding this comment.
This isn't necessarily the nicest way to test this. Reaching in with instance_variable_get is something of an antipattern, and I'll try other approaches.
There was a problem hiding this comment.
It's just a test, so if it works and handles the case the test is for, im good with it :)
…bundler as an explicit development dep
Testing on version 2.1, 2.2 and 2.3. Also including `sudo: false` as the error message from the previous build seems to be references here: rubygems/bundler#3558
|
Honestly maintenance of this is a low priority so whatever work you can contribute will be awesome. Feel free to use whatever tools you deem best, I trust you know what will work well since you've been using it frequently. I'm happy to merge when you think it's ready. |
|
Tests are passing @tuttinator, it's been far too long and I apologize getting back to you. Do you think this is merge ready? |
mileszim
left a comment
mileszim
left a comment
There was a problem hiding this comment.
@tuttinator I'm going to work off this branch to get tests in before i merge this and start updating dependencies, is that alright with you?
|
Great work! I borrowed your scaffold and am going from there. Thank you! Closing this in favor of #17 |
2 participants
Referencing to #6
This is my first approach at adding some tests. Not ready to merge yet, and I'll keep adding to this PR as I go - but I thought I'd open it early to allow you to provide feedback instead of one large PR all at once.
I've added a
Rakefileas Travis CI will just runrakeby default.I've also thought about using VCR to stub HTTP requests - so that testing API calls don't hit real servers.
Feel free to let me know if there are any stylistic changes you prefer.