ci: drop the unused bun and deno runtimes - #13
Merged
Merged
Conversation
Nothing in the repo runs under bun or deno (there are no tests/bun or tests/deno suites), so installing those runtimes only slows the job. The node runtime stays since it is what the matrix tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YD9ddxDTLrRmbwtVjgfwLC
Neither folder exists, so the excludes in vitest.config.ts and tsconfig.json matched nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YD9ddxDTLrRmbwtVjgfwLC
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- CI drops unused runtimes —
.github/workflows/ci.yamlno longer runspnpm runtime set bun 1orpnpm runtime set deno 2intest_node_matrix; thepnpm runtime set node ${{ matrix.node-version }}step stays to pin the matrix version. - Stale tsconfig excludes removed —
tsconfig.jsonexcludebecomes["playgrounds/**"]. - Stale vitest excludes removed —
vitest.config.tsdrops./tests/bun/**and./tests/deno/**fromtest.excludeandcoverage.exclude(benchmark.excludenever had them).
Verified independently: no tests/ directory exists, a repo-wide grep finds no remaining tests/bun/tests/deno or bun/deno runtime setup, and the only bun/deno references left are the legitimate package-manager detection in packages/uncheck/src/pm.ts and the README bunx note. CI is green on 76e3fd0.
DeepSeek Flash (default — pick a model for stronger reviews) | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Nothing in the repo runs on bun or deno, so this removes their setup from CI and the leftover config that referred to them.
test_node_matrixjob no longer runspnpm runtime set bun 1orpnpm runtime set deno 2. Thepnpm runtime set nodestep stays, since it sets the Node version for each matrix run (26, 24, 22).tests/bun/**andtests/deno/**excludes fromvitest.config.ts(tests and coverage) andtsconfig.json. Neither folder exists, so these excludes had nothing to exclude.Locally, sherif, oxlint, oxfmt and tsc pass, and all 118 vitest tests pass.
🤖 Generated with Claude Code
https://claude.ai/code/session_01YD9ddxDTLrRmbwtVjgfwLC
Generated by Claude Code