Skip to content

ci: drop the unused bun and deno runtimes - #13

Merged
dinwwwh merged 2 commits into
mainfrom
claude/friendly-cori-l7b65t
Sep 25, 2026
Merged

dinwwwh merged 2 commits into
mainfrom
claude/friendly-cori-l7b65t

Conversation

@dinwwwh

@dinwwwh dinwwwh commented Sep 24, 2026

Copy link
Copy Markdown
Member

Nothing in the repo runs on bun or deno, so this removes their setup from CI and the leftover config that referred to them.

  • CI: the test_node_matrix job no longer runs pnpm runtime set bun 1 or pnpm runtime set deno 2. The pnpm runtime set node step stays, since it sets the Node version for each matrix run (26, 24, 22).
  • Config: removes the tests/bun/** and tests/deno/** excludes from vitest.config.ts (tests and coverage) and tsconfig.json. Neither folder exists, so these excludes had nothing to exclude.

Locally, sherif, oxlint, oxfmt and tsc pass, and all 118 vitest tests pass.

🤖 Generated with Claude Code

https://claude.ai/code/session_01YD9ddxDTLrRmbwtVjgfwLC


Generated by Claude Code

Nothing in the repo runs under bun or deno (there are no tests/bun or
tests/deno suites), so installing those runtimes only slows the job.
The node runtime stays since it is what the matrix tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YD9ddxDTLrRmbwtVjgfwLC
Neither folder exists, so the excludes in vitest.config.ts and
tsconfig.json matched nothing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YD9ddxDTLrRmbwtVjgfwLC
@pkg-pr-new

pkg-pr-new Bot commented Sep 24, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/uncheck@13

commit: 76e3fd0

@codecov

codecov Bot commented Sep 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • CI drops unused runtimes — .github/workflows/ci.yaml no longer runs pnpm runtime set bun 1 or pnpm runtime set deno 2 in test_node_matrix; the pnpm runtime set node ${{ matrix.node-version }} step stays to pin the matrix version.
  • Stale tsconfig excludes removed — tsconfig.json exclude becomes ["playgrounds/**"].
  • Stale vitest excludes removed — vitest.config.ts drops ./tests/bun/** and ./tests/deno/** from test.exclude and coverage.exclude (benchmark.exclude never had them).

Verified independently: no tests/ directory exists, a repo-wide grep finds no remaining tests/bun/tests/deno or bun/deno runtime setup, and the only bun/deno references left are the legitimate package-manager detection in packages/uncheck/src/pm.ts and the README bunx note. CI is green on 76e3fd0.

Pullfrog  | View workflow run | Using DeepSeek Flash (default — pick a model for stronger reviews) | 𝕏

@dinwwwh
dinwwwh merged commit 3561fbd into main Sep 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants