Skip to content

feat: add HTTP Gone error#1435

Open
ctjhoa wants to merge 1 commit intomiddleapi:mainfrom
ctjhoa:feat/add-gone-error
Open

feat: add HTTP Gone error#1435
ctjhoa wants to merge 1 commit intomiddleapi:mainfrom
ctjhoa:feat/add-gone-error

Conversation

@ctjhoa
Copy link

@ctjhoa ctjhoa commented Feb 18, 2026

https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Status/410

Summary by CodeRabbit

  • New Features

    • Added GONE (HTTP 410) error status to supported error responses.
  • Documentation

    • Updated error handling documentation to reflect the new GONE error mapping in default error set.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 18, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ctjhoa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the system's error handling capabilities by integrating the HTTP 410 Gone status code. This allows for more precise communication when a resource has been permanently removed, improving client-side error management and API clarity by providing a distinct status for resources that are no longer available.

Highlights

  • New Error Definition: Introduced the GONE (HTTP 410) error to the system's common error definitions, allowing for explicit indication that a resource is permanently unavailable.
  • Documentation Update: Updated the OpenAPI error handling documentation to include the newly added GONE error, ensuring consistency and clarity for API consumers.
Changelog
  • apps/content/docs/openapi/error-handling.md
    • Added an entry for the GONE error (HTTP 410) to the table of common oRPC error codes.
  • packages/client/src/error.ts
    • Defined the GONE error with status code 410 and message 'Gone' within the COMMON_ORPC_ERROR_DEFS object.
Activity
  • No activity has occurred on this pull request since its creation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link

coderabbitai bot commented Feb 18, 2026

📝 Walkthrough

Walkthrough

Introduces a new GONE error code with HTTP status 410 across the error handling system, including both the client-side error definition and documentation update.

Changes

Cohort / File(s) Summary
GONE Error Code Addition
packages/client/src/error.ts, apps/content/docs/openapi/error-handling.md
Adds GONE error code (HTTP 410) to COMMON_ORPC_ERROR_DEFS and documents the new error mapping in the Default Error Mappings table.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A GONE code hops in, 410 bright,
Where errors find rest in the digital night,
Documentation updated with care,
The mapping complete, beyond compare! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat: add HTTP Gone error' accurately reflects the main change—adding a new GONE error code with HTTP 410 status across documentation and client code.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the GONE (410) HTTP error, updating both the error definitions in the client package and the corresponding documentation. The changes are consistent and follow the existing structure. I've added one comment regarding test coverage for the new error code.

@dosubot dosubot bot added the enhancement New feature or request label Feb 18, 2026
@unnoq
Copy link
Member

unnoq commented Feb 19, 2026

I'll consider adding this in v2, since it would be a breaking change: projects that currently throw a GONE error return status 500, but after this PR it would return 410.

@unnoq unnoq added the v2 label Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size:XS This PR changes 0-9 lines, ignoring generated files. v2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments