Skip to content

ci: prevent command injection in release workflow #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dinwwwh wants to merge 1 commit into
base: main
Choose a base branch
from
+24 −17
Open

ci: prevent command injection in release workflow #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 24 additions & 17 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,26 +37,30 @@ jobs:
permissions:
contents: write
id-token: write
env:
VERSION: ${{ inputs.version }}
steps:
- id: version
env:
TAG_INPUT: ${{ inputs.tag }}
run: |
VERSION="${{ github.event.inputs.version }}"
if [[ ! $VERSION =~ ^(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)(-([a-z]+)\.([1-9][0-9]*))?$ ]]; then
echo "INVALID VERSION FORMAT: $VERSION" >&2
exit 1
fi

if [[ $VERSION =~ ^(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)(-([a-z]+)\.([1-9][0-9]*))?$ ]]; then
if [[ "${BASH_REMATCH[5]}" == "latest" ]]; then
echo "INVALID VERSION FORMAT ('latest' is not allowed): $VERSION" >&2
exit 1
fi
PREID="${BASH_REMATCH[5]}"
if [[ $PREID == "latest" ]]; then
echo "INVALID VERSION FORMAT ('latest' is not allowed): $VERSION" >&2
exit 1
fi

echo "major=${BASH_REMATCH[1]}" >> $GITHUB_OUTPUT
echo "minor=${BASH_REMATCH[2]}" >> $GITHUB_OUTPUT
echo "patch=${BASH_REMATCH[3]}" >> $GITHUB_OUTPUT
echo "preid=${BASH_REMATCH[5]}" >> $GITHUB_OUTPUT
echo "number=${BASH_REMATCH[6]}" >> $GITHUB_OUTPUT
else
echo "INVALID VERSION FORMAT: $VERSION" >&2
TAG="${TAG_INPUT:-${PREID:-latest}}"
if [[ ! $TAG =~ ^[a-z][a-z0-9._-]*$ ]]; then
echo "INVALID TAG FORMAT: $TAG" >&2
exit 1
fi
echo "tag=$TAG" >> "$GITHUB_OUTPUT"

- uses: actions/checkout@v7
with:
Expand All @@ -70,12 +74,15 @@ jobs:
git config --global user.name "github-actions[bot]"
git config --global user.email "github-actions[bot]@users.noreply.github.com"

- run: pnpm exec bumpp -r ${{ github.event.inputs.version }} --yes
if: ${{ github.event.inputs.skip_bump != 'true' }}
- run: pnpm exec bumpp -r "$VERSION" --yes
if: ${{ !inputs.skip_bump }}

- run: pnpm exec changelogithub --draft
if: ${{ github.event.inputs.skip_changelog != 'true' }}
if: ${{ !inputs.skip_changelog }}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- run: pnpm --filter='./packages/*' publish -r --provenance --access=public --tag=${{ github.event.inputs.tag || steps.version.outputs.preid || 'latest' }} ${{ github.event.inputs.skip_git_check == 'true' && '--no-git-checks' || '' }}
- run: pnpm --filter='./packages/*' publish -r --provenance --access=public --tag="$TAG" $NO_GIT_CHECKS
env:
TAG: ${{ steps.version.outputs.tag }}
NO_GIT_CHECKS: ${{ inputs.skip_git_check && '--no-git-checks' || '' }}
Loading