feat(styles): size the team icon on assignee chips to the chip line - #8084
Merged
Merged
Conversation
The calendar task modal's assignee picker renders selected team chips with a mat-icon (`calendar-assignee-team-icon`). mat-icon keeps its 24x24 box, so team chips were taller than worker chips. Size the icon to 16px on the chip line, with specificity above the `.md-18` icon rules; colour is inherited from the chip under both themes. Refs microting/eform-backendconfiguration-plugin#1295 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified.
Pull request overview
This PR sizes team icons in calendar assignee chips to match worker chips.
Changes:
- Sets icons to 16px with middle alignment.
- Prevents flex shrinking while preserving inherited color.
File summaries
| File | Description |
|---|---|
eform-client/src/scss/components/_material-dropdown.scss |
Styles calendar team-assignee icons to match chip height. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed by microting/eform-backendconfiguration-plugin#1295 (part of epic microting/eform-backendconfiguration-plugin#1304).
#1295 merges teams into the task modal's
#calendarEventAssigneeselect. Selected team chips show agroupsicon (<mat-icon class="md-18 calendar-assignee-team-icon">). A mat-icon keeps a 24×24 box, so team chips came out taller than worker chips.This adds one global rule to
_material-dropdown.scss, next to the existingeform-worker-group-label/eform-worker-option-labelrules. It gives the icon a 16px box,vertical-align: middle, andflex-shrink: 0(theme-workspace chips are inline-flex).md-18rules at (0,3,0).🤖 Generated with Claude Code