feat(styles): shared row-highlight-flash animation for briefly highlighting a table row - #8083
Merged
Merged
Conversation
… a table row Adds a global `tr.row-highlight-flash > td` fade (4px blue inset outline plus a theme-aware powder tint, held for 70% of 3 s then faded) matching the task tracker's existing `.highlighted` look. It uses a new class rather than `highlight-row`, which existing plugin tables already style themselves, so those tables keep their current look. The tint uses background-image driven by a registered custom property so it also reaches pinned (sticky) cells, where box-shadow and background-color are forced with !important. Needed by microting/eform-backendconfiguration-plugin#1290 and #1291 (compliance report rows briefly highlighted after delete/edit). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Changes recommended
Existing pinned-cell background rules override the highlight tint and must be addressed.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds shared SCSS styling for a temporary, theme-aware table-row highlight animation.
Changes:
- Adds a 3-second blue outline and fading powder tint.
- Registers an animatable tint property.
- Preserves existing component-specific styles.
File summaries
| File | Summary |
|---|---|
eform-client/src/scss/components/_table.scss |
Adds shared row-highlight animation styling. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+233
to
+238
| tr.row-highlight-flash > td { | ||
| outline: 4px solid transparent; | ||
| outline-offset: -4px; | ||
| background-image: linear-gradient(var(--highlight-row-tint), var(--highlight-row-tint)); | ||
| animation: highlightRowFade 3s ease-out; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed by microting/eform-backendconfiguration-plugin#1290 and #1291 (part of epic microting/eform-backendconfiguration-plugin#1304). After deleting or editing a log in the Compliance Rapport view, the view scrolls to the relevant row and highlights it for about 3 s.
Per the repo rule, SCSS lives here and not in the plugin. This adds a global
tr.row-highlight-flash > tdrule tosrc/scss/components/_table.scss. The look matches the task tracker's existing highlight: a 4px#1e88e5inset outline plus a powder tint that fade out over 3 s.highlight-rowis already styled per-component by three plugin tables (property-workers, task-management, files). Those tables are left exactly as they are.background-image. It uses a registered@propertycolour. Animatingbackground-colororbox-shadowwould lose to the!importantrules on sticky cells in_workspace-mat-overrides.scss.--surface-powdertoken, which is defined for theme-eform and theme-workspace in both light and dark.🤖 Generated with Claude Code