Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
REST installer parsing did not require hashes, which is only acceptable for installer types where we do not control the download (Store-based MSIX installs only right now). Make not having a required hash result in an ignored installer, as we do for other required fields.
Hash validation further allowed the empty hash to accept anything. While that matches with some form of expectation, we don't really want that. Hash validation is now required to occur if the task is invoked.
🔍 Validation
Added new tests for the hash validation and REST response parsing.
Fixed a number of test overrides that relied on the validation skip.
Microsoft Reviewers: Open in CodeFlow