[cherry-pick] test: remove external network dependency from browser tools - #337048
Merged
Merged
Conversation
vs-code-engineering
Bot
added
the
cherry-pick-artifact
Contributor
Author
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Kyle Cutler (@kycutler)Matched files:
Joaquín Ruales (@jruales)Matched files:
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused change removes network flakiness while preserving coverage and reliable cleanup.
Review effort: Balanced
Findings: None
What changed in this PR
Replaces an external browser test dependency with a deterministic loopback HTTP server while preserving remote proxy coverage.
Changes:
- Serves a local HTTP fixture from the extension host.
- Verifies both page ID and rendered content.
- Closes the server and connections reliably.
| File | Description |
|---|---|
| extensions/vscode-api-tests/src/singlefolder-tests/browser.tools.test.ts | Reworks the browser tool test to use a local HTTP fixture. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Christof Marti (chrmarti)
approved these changes
Sep 21, 2026
Christof Marti (chrmarti)
enabled auto-merge (squash)
September 21, 2026 14:49
Contributor
Screenshot ChangesBase: Changed (2)
|
| Before | After |
|---|---|
 |
 |
sessions/sessionChatInputToolbar/SessionChatPills_HorizontalOverflow/Light
| Before | After |
|---|---|
 |
 |
1 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.
Dirk Bäumer (dbaeumer)
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #336988 from
main.Summary
Investigated the failed original attempts in Insider run 20260921.4 / 475409.
chat - browser tools > Open a page from the webtimed out navigating tohttps://google.com/after 30 seconds (log 2192). Replace this external dependency with a loopback HTTP server in the extension host, verify that the tool returns both a page ID and the served content, and close the server/connections infinally. The test stays enabled in remote workspaces and exercises the remote browser proxy there. No retries, timeout increases, or test skips.peer chat catalog and transcript survive a host restartfailed withResource not found(log 1951). Fix peer chat catalog migration racing with chat creation #336975 fixes the matching catalog-migration race, passed its own cross-platform Azure validation, and has now merged. That fix is not duplicated here.Also checked #331912 (remote browser proxy readiness); it does not remove this test's dependency on an external website.
Validation
chat - browser toolsintegration tests passed against installed Windows Insiders, including the new HTTP test (231 ms). Five additional isolated HTTP-test runs also passed (639-758 ms).@vscode/policy-watchernative binding; used installed Insiders rather than modifying shared native dependencies.ddfc38a8a2a(finished 2026-09-21 09:52 UTC). All seven stages passed, including Windows x64, Linux x64, and macOS arm64, with publishing/release disabled and tests enabled. The originally failing macOS arm64 Remote integration step passed; the replacement HTTP test completed in 118 ms (log 1230).