[cherry-pick] Enable Modern UI Update by default - #337037
Open
Lee Murray (mrleemurray) wants to merge 1 commit into
Open
Lee Murray (mrleemurray) wants to merge 1 commit into
Lee Murray (mrleemurray) wants to merge 1 commit into
Conversation
Copilot started reviewing on behalf of
Lee Murray (mrleemurray)
September 21, 2026 14:04
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The backport matches the merged source PR and the compatibility changes follow existing automation patterns.
Review effort: Balanced
Findings: None
What changed in this PR
Enables Modern UI by default while preserving rollout metadata and updating affected smoke-test automation.
Changes:
- Defaults Modern UI to enabled.
- Updates chat model-picker resizing for floating layouts.
- Stabilizes terminal persistence reload testing.
| File | Description |
|---|---|
src/vs/workbench/browser/workbench.contribution.ts |
Enables Modern UI by default. |
test/automation/src/chat.ts |
Locates the rendered workbench sash when resizing chat. |
test/smoke/src/areas/terminal/terminal-persistence.test.ts |
Improves reload and terminal-focus sequencing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
4 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.
Lee Murray (mrleemurray)
enabled auto-merge
September 21, 2026 15:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #337013 from
main.Summary
workbench.experimental.modernUIby default while preserving explicit user and workspace opt-outsValidation
npm run eslint -- src/vs/workbench/browser/workbench.contribution.ts test/automation/src/chat.ts test/smoke/src/areas/terminal/terminal-persistence.test.tscd test/smoke && npm run compile