sessions: revert Customizations sidebar reorganization - #337007
Merged
Sandeep Somavarapu (sandy081) merged 6 commits intoSep 21, 2026
Merged
Sandeep Somavarapu (sandy081) merged 6 commits into
Sandeep Somavarapu (sandy081) merged 6 commits into
Conversation
Keep the existing expandable Customizations pane as the control and switch dynamically to the single list entry for the automatic treatment. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sandeep Somavarapu (sandy081)
enabled auto-merge (squash)
September 21, 2026 10:21
Copilot started reviewing on behalf of
Sandeep Somavarapu (sandy081)
September 21, 2026 10:22
View session
Christof Marti (chrmarti)
previously approved these changes
Sep 21, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The restored control has duplicate command execution, broken toolbar focus behavior, and incomplete feature gating.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 4
Open (5)
What changed in this PR
Gates the Customizations list entry behind an experiment while restoring the expandable pane as the control for #336787.
Changes:
- Adds the hidden automatic experiment setting.
- Reactively switches between list-entry and pane variants.
- Restores the Customizations toolbar and keeps fixtures on treatment.
| File | Description |
|---|---|
sessionsList.fixture.ts |
Enables treatment in fixtures. |
sessions.common.main.ts |
Loads the toolbar contribution. |
sessionsList.test.ts |
Tests list treatment/control switching. |
sessions.contribution.test.ts |
Verifies experiment schema. |
sessionsView.ts |
Restores and switches the control pane. |
sessionsList.ts |
Gates the list entry and header placement. |
sessions.contribution.ts |
Registers the experiment setting. |
customizationsToolbar.css |
Styles the restored pane. |
customizationsToolbar.contribution.ts |
Registers toolbar actions and rows. |
customizationsConstants.ts |
Defines setting and treatment IDs. |
aiCustomizationShortcutsWidget.ts |
Implements the expandable pane. |
menus.ts |
Restores the Customizations menu. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Fix restored toolbar counting and focus behavior, preserve focus across experiment switches, and hide the control pane when AI features are unavailable. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sandeep Somavarapu (sandy081)
disabled auto-merge
September 21, 2026 10:40
Sandeep Somavarapu (sandy081)
changed the title
Christof Marti (chrmarti)
previously approved these changes
Sep 21, 2026
Contributor
Screenshot ChangesBase: Changed (24)
|
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge/DarkHighContrast
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_LightweightNewButton/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_LightweightNewButton/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_LightweightNewButton/DarkHighContrast
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_LightweightNewButtonWithKeybindingBackground/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_LightweightNewButtonWithKeybindingBackground/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_LightweightNewButtonWithKeybindingBackground/DarkHighContrast
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge_Accent/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge_Accent/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge_Accent/DarkHighContrast
| Before | After |
|---|---|
|
|
sessions/sessionsList/SessionsList_AutomationsNewBadge_Soft/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge_Soft/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge_Soft/DarkHighContrast
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge_Unread/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge_Unread/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge_Unread/DarkHighContrast
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge_Narrow/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge_Narrow/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge_Narrow/DarkHighContrast
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge_Running/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge_Running/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge_Running/DarkHighContrast
| Before | After |
|---|---|
 |
 |
2 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.
Added (10)
sessions/aiCustomizationShortcutsWidget/Expanded/Dark
sessions/aiCustomizationShortcutsWidget/Expanded/Light
sessions/aiCustomizationShortcutsWidget/MinimumHeight/Dark
sessions/aiCustomizationShortcutsWidget/MinimumHeight/Light
sessions/aiCustomizationShortcutsWidget/WithMcpServers/Dark
sessions/aiCustomizationShortcutsWidget/WithMcpServers/Light
sessions/aiCustomizationShortcutsWidget/MinimumHeightWithMcpServers/Dark
sessions/aiCustomizationShortcutsWidget/MinimumHeightWithMcpServers/Light
sessions/aiCustomizationShortcutsWidget/WithCounts/Dark
sessions/aiCustomizationShortcutsWidget/WithCounts/Light
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sandeep Somavarapu (sandy081)
enabled auto-merge
September 21, 2026 12:34
Sandeep Somavarapu (sandy081)
disabled auto-merge
September 21, 2026 12:34
Sandeep Somavarapu (sandy081)
enabled auto-merge (squash)
September 21, 2026 12:34
Christof Marti (chrmarti)
approved these changes
Sep 21, 2026
Sandeep Somavarapu (sandy081)
deleted the
sandy081/agents/customizations-sidebar-experiment
branch
September 21, 2026 13:06
Sandeep Somavarapu (sandy081)
added
the
~release-cherry-pick
vs-code-engineering
Bot
added
release-cherry-pick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
npm run compilenpm run typecheck-clientnpm run transpile-client && ./scripts/test.sh --run src/vs/sessions/contrib/sessions/test/browser/sessionsList.test.ts --run src/vs/sessions/contrib/sessions/test/browser/sessionsViewPane.test.ts(146 passing)npm run hygienenpm run valid-layers-checkgit diff --check