Disable editing pending steering messages - #336895
Draft
Joaquín Ruales (jruales) wants to merge 5 commits into
Draft
Joaquín Ruales (jruales) wants to merge 5 commits into
Joaquín Ruales (jruales) wants to merge 5 commits into
Conversation
Fixes #325884 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Joaquín Ruales (jruales)
September 19, 2026 22:12
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved queue and abort races can still send superseded or cancelled work.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 2
Open (4)
What changed in this PR
Synchronizes pending Copilot steering edits with the SDK queue.
Changes:
- Serializes queue mutations and retracts superseded steering.
- Handles consumption, cancellation, and unrelated queued work.
- Adds regression coverage for editing and lifecycle races.
| File | Description |
|---|---|
| src/vs/platform/agentHost/test/node/copilotAgentSession.test.ts | Adds steering queue regression tests. |
| src/vs/platform/agentHost/node/copilot/copilotAgentSession.ts | Implements steering queue reconciliation and serialization. |
| src/vs/platform/agentHost/node/copilot/copilotAgent.ts | Routes pending steering state to the session. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Replace SDK queue reconciliation with shared UI editing guards. Preserve queued and sent request editing and restore the provider's existing send, cancel, and model-switch behavior. Fixes #325884 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Joaquín Ruales (jruales)
changed the title
Copilot started reviewing on behalf of
Joaquín Ruales (jruales)
September 20, 2026 19:59
View session
Include the pending kind in request rendering identity so queued-to-steering transitions refresh edit controls and listeners. Cover both transition directions through the real chat list. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Joaquín Ruales (jruales)
September 20, 2026 22:00
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
An active queued edit can survive a transition to steering and submit using stale queue state.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Resolved since last review (1)
Check the live pending request state before preparing an edit and again before replacing the queued request. Reject stale edits with a warning while retaining the user's input. Refs #325884 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Joaquín Ruales (jruales)
September 20, 2026 22:22
View session
Preserve both pending-steering accessibility coverage and the upstream draft-handoff accessibility tests. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The editing restriction and state-transition safeguards have focused regression coverage, with only minor wording feedback remaining.
Review effort: Balanced
Findings: None
Resolved since last review (1)
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
6 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #325884.
Disable editing of pending steering messages to prevent multiple revisions from being sent to the agent. Queued and sent messages remain editable; provider send, cancellation, and model-switch behavior is unchanged.
Apply the restriction to toolbar, mouse, keyboard, and programmatic edit entry points. Add regression coverage and update accessibility help.