Only show onboarding microphone picker once a real mic is detected

[Copilot]

Description

The voice-mode and dictation onboarding cards could render the microphone picker before device names were available, showing a blank selected mic or "Unknown device" rows.

Both cards guard picker rendering behind a "wait for real labels" check, but that check inspected IMicrophoneOption.label — which buildMicrophoneOptions() always fills with an "Unknown device (…)" fallback, making it unconditionally truthy. As a result the guard never fired, and a multi-mic picker rendered blank before microphone permission was granted.

• Gate on raw device labels — refreshMicrophones() in both dictationOnboarding.ts and voiceModeOnboarding.ts now bails when there are multiple options but no MediaDeviceInfo reports a real label:

  if (options.length > 1 && !devices.some(device => device.kind === 'audioinput' && device.label)) {
      return;
  }

  The picker stays hidden until named mics are detected, then renders (and keeps updating via the existing devicechange listener). A single mic still never shows a picker.

• Dropped the this.options.length > 1 precondition that previously let the first render slip through unlabeled, so the gate applies from the initial refresh.

• Test — added coverage asserting the dictation picker stays hidden while mics are unlabeled and appears with correct options once a real label lands.

• Fixes Microphone picker shows when there's only one mic but shouldn't #328849

[Copilot]

Pull request overview

Fixes premature microphone picker rendering before device labels are available.

Changes:

• Gates both onboarding pickers on real microphone labels.
• Adds dictation regression coverage for dynamic label availability.

Show a summary per file

File	Description
dictationOnboarding.ts	Defers dictation picker rendering.
voiceModeOnboarding.ts	Defers Voice Mode picker rendering.
dictationOnboarding.test.ts	Tests unlabeled-to-labeled behavior.

Review details

Suppressed comments (1)

src/vs/workbench/contrib/agentsVoice/browser/voiceModeOnboarding.ts:780

• The regression test covers only DictationOnboardingBanner, but this independent Voice Mode branch can still regress unnoticed even though the issue and PR explicitly cover both cards. Please add the equivalent unlabeled-to-labeled picker test in agentsVoice/test/browser/voiceModeOnboarding.test.ts.

		if (options.length > 1 && !devices.some(device => device.kind === 'audioinput' && device.label)) {

• Files reviewed: 3/3 changed files
• Comments generated: 3
• Review effort level: Balanced