Skip to content

Drop pill border on single-icon voice/dictation toggle - #328834

Merged
Megan Rogge (meganrogge) merged 3 commits into
mainfrom
copilot/remove-border-from-voice-buttons
Aug 4, 2026
Merged

Drop pill border on single-icon voice/dictation toggle#328834
Megan Rogge (meganrogge) merged 3 commits into
mainfrom
copilot/remove-border-from-voice-buttons

Conversation

Copilot AI commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Description

When only one of the voice/dictation buttons is present, the segmented-icon toggle still rendered its housing border, boxing a lone button in a way that's inconsistent with VS Code's other borderless input controls.

The control is built on the generic segmented-icon-toggle chrome. When exactly one cell is present, voiceInputModeActionViewItem already tags the container with single, but nothing cleared the now-meaningless divider border.

  • segmentedIconToggle.css: hide the housing border in the single-icon view.
.monaco-segmented-icon-toggle-container.single .monaco-segmented-icon-toggle {
	border-color: transparent;
}

Uses border-color: transparent (not border: none) so the border box still occupies space, keeping width/layout stable across single ↔ multi transitions. The divider border is unchanged when two or more cells are shown. Applies to both the main chat input and the Agents window since they share the component.

Co-authored-by: meganrogge <29464607+meganrogge@users.noreply.github.com>
Copilot AI requested review from Copilot and removed request for Copilot August 3, 2026 20:42
Copilot AI changed the title [WIP] Fix border appearance for voice buttons when one is active Drop pill border on single-icon voice/dictation toggle Aug 3, 2026
@meganrogge
Megan Rogge (meganrogge) marked this pull request as ready for review August 4, 2026 20:21
Copilot AI balanced review requested due to automatic review settings August 4, 2026 20:21
@meganrogge
Megan Rogge (meganrogge) enabled auto-merge (squash) August 4, 2026 20:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes unnecessary chrome around a lone voice/dictation action while preserving stable control dimensions.

Changes:

  • Makes the segmented-toggle housing border transparent in single-icon mode.
  • Retains border-box spacing across single/multi transitions.
Show a summary per file
File Description
src/vs/base/browser/ui/segmentedIconToggle/segmentedIconToggle.css Hides the housing border for single-icon toggles.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Balanced

@meganrogge
Megan Rogge (meganrogge) merged commit be52508 into main Aug 4, 2026
29 checks passed
@meganrogge
Megan Rogge (meganrogge) deleted the copilot/remove-border-from-voice-buttons branch August 4, 2026 22:54
@vs-code-engineering vs-code-engineering Bot added this to the 1.133.0 milestone Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

If you only have 1 of the voice buttons active I don't think the border makes sense

5 participants