Drop pill border on single-icon voice/dictation toggle - #328834
Merged
Megan Rogge (meganrogge) merged 3 commits intoAug 4, 2026
Conversation
Co-authored-by: meganrogge <29464607+meganrogge@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix border appearance for voice buttons when one is active
Drop pill border on single-icon voice/dictation toggle
Aug 3, 2026
Megan Rogge (meganrogge)
approved these changes
Aug 4, 2026
Megan Rogge (meganrogge)
marked this pull request as ready for review
August 4, 2026 20:21
Megan Rogge (meganrogge)
enabled auto-merge (squash)
August 4, 2026 20:21
Contributor
There was a problem hiding this comment.
Pull request overview
Removes unnecessary chrome around a lone voice/dictation action while preserving stable control dimensions.
Changes:
- Makes the segmented-toggle housing border transparent in single-icon mode.
- Retains border-box spacing across single/multi transitions.
Show a summary per file
| File | Description |
|---|---|
src/vs/base/browser/ui/segmentedIconToggle/segmentedIconToggle.css |
Hides the housing border for single-icon toggles. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
Ben Villalobos (benvillalobos)
approved these changes
Aug 4, 2026
Megan Rogge (meganrogge)
approved these changes
Aug 4, 2026
Vritant Bhardwaj (vritant24)
approved these changes
Aug 4, 2026
Megan Rogge (meganrogge)
deleted the
copilot/remove-border-from-voice-buttons
branch
August 4, 2026 22:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When only one of the voice/dictation buttons is present, the segmented-icon toggle still rendered its housing border, boxing a lone button in a way that's inconsistent with VS Code's other borderless input controls.
The control is built on the generic segmented-icon-toggle chrome. When exactly one cell is present,
voiceInputModeActionViewItemalready tags the container withsingle, but nothing cleared the now-meaningless divider border.segmentedIconToggle.css: hide the housing border in the single-icon view.Uses
border-color: transparent(notborder: none) so the border box still occupies space, keeping width/layout stable across single ↔ multi transitions. The divider border is unchanged when two or more cells are shown. Applies to both the main chat input and the Agents window since they share the component.