Fix default thinking effort - #328783
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds fallback thinking-effort defaults for Agent Host models and avoids rendering undefined picker labels.
Changes:
- Resolves model-family-specific reasoning defaults.
- Tests fallback behavior across model families.
- Hides picker labels without effective values.
Show a summary per file
| File | Description |
|---|---|
modelPickerConfiguration.ts |
Handles missing configuration values. |
copilotAgent.test.ts |
Tests fallback defaults. |
copilotAgent.ts |
Applies resolved defaults to schemas. |
reasoningEffort.ts |
Adds default-resolution logic. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 3
- Review effort level: Balanced
vritant24
previously approved these changes
Aug 3, 2026
lramos15
disabled auto-merge
August 3, 2026 18:30
- Trim resolveDefaultReasoningEffort JSDoc to the stable contract - Filter reasoning efforts to launcher-supported levels inside the schema helper so unsupported levels are never advertised or chosen as default - Guarantee a default in the Copilot CLI extension producer via pickDefaultReasoningEffort - Keep the model picker configuration button actionable instead of hiding it Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 88afcac4-196d-4577-b429-b2c5b802bf57
lramos15
added
the
~release-cherry-pick
Contributor
|
This PR will be automatically cherry-picked to |
lramos15
enabled auto-merge (squash)
August 3, 2026 19:48
pwang347
approved these changes
Aug 3, 2026
justschen
approved these changes
Aug 3, 2026
vs-code-engineering
Bot
added
release-cherry-pick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.